#33263: DeleteView in Django4.0 does not call .delete() method
-------------------------------------+------------------------------------
Reporter: Eugene Prikazchikov | Owner: nobody
Type: Bug | Status: new
Component: Generic views | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+------------------------------------
Comment (by Eugene Prikazchikov):
I understand that with new approach you need to move that kind of logic to
`form_valid()`, not to 'delete()` and I like that idea.
I was lucky enough to detect the broken behavior early on - the project is
covered by unit tests quite well and tests started to fail.
When migrating project without much tests, you can easily miss it, your
delete method will just be silently ignored. In the worst case you will
know about the problem only when your users start to complain.
I am wondering if we could make it more obvious to developers that
behavior has changed and their existing code **must** be updated.
Normally such breaking changes should be taken through deprecation
process, no?
--
Ticket URL: <https://code.djangoproject.com/ticket/33263#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.354076d4748787f380a6ee73fe20da81%40djangoproject.com.
