#33253: Collectstatic fails when using ManifestStaticFilesStorage and specific
Javascript file
-------------------------------------+-------------------------------------
Reporter: Hervé Le Roy | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: contrib.staticfiles | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
ManifestStaticFilesStorage |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* owner: nobody => Carlton Gibson
* status: new => assigned
* has_patch: 0 => 1
Comment:
I've opened a [https://github.com/django/django/pull/15058 draft PR] for
this that tightens the regex to ≈valid identifiers plus `{},\s ` due to
appearing in the `import`/`export`.
I'm sure it can be improved. Comments welcome there.
> removed the 's' in (?s: (Regex101 was reporting it as incorrect in
Python regex syntax, and, anyway, Javascript import statement can be
multi-line
`(?s)` is [https://docs.python.org/3.10/library/re.html#re.DOTALL
`re.DOTALL`] allowing `.` to match newlines, which matters for the multi-
line case.
--
Ticket URL: <https://code.djangoproject.com/ticket/33253#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.fbfe56879b78b077f7a19327b0cc7c02%40djangoproject.com.
