#33256: Some schema tests don't clean up their tables
-------------------------------------+-------------------------------------
     Reporter:  Tim Graham           |                    Owner:  banani720
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  dev
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

 > If I have not done all of the cases yet, but just want to check in to
 see if I am going about this the correct way, should I still submit a pr?

 I don't think there is a need to submit PR at this stage. You should be
 able to [https://docs.djangoproject.com/en/3.2/internals/contributing
 /writing-code/unit-tests/ run tests locally] and check that all `schema`
 tests work:
 {{{
 ./runtests.py --settings=test_postgres --parallel=1 --keepdb schema
 }}}
 I'd submit PR when all test pass.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33256#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.73a4d1370eafc92656956658d7054690%40djangoproject.com.

Reply via email to