#33258: inconsistent use of () and [] for attributes in ModelAdmin class - Also
class variables
--------------------------------+--------------------------------------
Reporter: newearthmartin | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution:
Keywords: Admin | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Changes (by Carlton Gibson):
* cc: Claude Paroz (added)
Comment:
OK, I think this needs to go to the DevelopersMailingList.
There was some movement towards lists (not necessarily in these exact
locations) in #30947 and [https://github.com/django/django/pull/11267 PR
11267].
The idea was the homogenous lists should lists, where other iterables
where the fields were of different kinds should use tuples.
(I defer the question of which applies where in the case raised here.)
> And also since these are declared in the class, they are shared among
all instances if this value is not set.
> ...
> While lists are more semantically correct than tuples, tuples have the
advantage of being immutable, so they force users to reset the value every
time.
This seems more pressing.
[https://github.com/django/django/commit/97d3321e89c8d4434927bdbc308db1ccffa99d3b#commitcomment-33558481
Claude raise this worry in the discussion on the commit for the PR 11267]
> ... I think we should consider the impact on mutability too. Don't we
get a new risk here where people might suddenly change a class-level list
...
I'm not sure what the best way to balance the considerations is, but I
think it's worth asking for input.
--
Ticket URL: <https://code.djangoproject.com/ticket/33258#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/072.2102920e35a43a54b0b3714ccf4718a5%40djangoproject.com.
