#33220: Test suite failures when using PYTHONOPTIMIZE or optimization CLI flags
-------------------------------------+-------------------------------------
     Reporter:  Keryn Knight         |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  Testing framework    |                  Version:  dev
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

 Replying to [comment:2 Jacob Walls]:
 > Keryn, your point about the second subtest of
 `test_get_version_invalid_version()` passing without testing what it
 claims to test looks valid to me. I would hazard that would be a welcome
 cleanup PR (and could ref this ticket number, even, maybe, to suggest how
 it was found).


 `get_version()` is an internal Django utility, so I'd not change this (see
 [https://github.com/django/django/pull/14114#discussion_r592669163
 comment]).

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33220#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3f5adc5a768866255ada1f2334937d65%40djangoproject.com.

Reply via email to