#33098: Micro-optimisation for functional.keep_lazy for single argument uses.
-------------------------------------+-------------------------------------
Reporter: Keryn Knight | Owner: Keryn
Type: | Knight
Cleanup/optimization | Status: assigned
Component: Template system | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Keryn Knight):
* needs_tests: 1 => 0
Comment:
I've added tests, but they're not _good_ ones, really. Hence this remains
on patch needs improvement.
Specifically the tests demonstrate that re-wrapping with a different
specialised wrapper doesn't cause the exceptions to _change_ when called
incorrectly, and covers calling it in a bunch of different ways. **But**
the tests _don't_ demonstrate which wrapper they passed through, or that
they correctly use the `lazy_func`. I'd need some guidance on how to
approach testing those aspects.
Linters are currently preventing it from being marked as successful
(because of course they are), but the tests ''pass'', such as they are.
--
Ticket URL: <https://code.djangoproject.com/ticket/33098#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.079be124f26d246c16cd4adb59a73725%40djangoproject.com.
