#32958: URLValidator tests don't obviously test how long validation takes
-----------------------------------+--------------------------------------
Reporter: Chris Jerdonek | Owner: nobody
Type: Uncategorized | Status: closed
Component: Testing framework | Version: dev
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Mariusz Felisiak):
* status: new => closed
* resolution: => needsinfo
Comment:
> However, it's not obvious whether the test actually checks how long the
validation takes, or what "forever" really means (e.g. is 1 second
forever?). For example, I couldn't see any measurement of elapsed time in
the tests.
In this case "forever" means minutes (maybe hours). It's hard to estimate
an upper bound, there are too many variables and we don't want to add a
flaky test that fails on contributors computers.
> ... if necessary, the test could check that validation doesn't take too
long.
Do you have a suggestion on how to handle this?
We can clarify a comment, but I don't think it's feasible to add a not
error-prone test based on runtime.
--
Ticket URL: <https://code.djangoproject.com/ticket/32958#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.4f5372b3b86032d4764055aec9217a7d%40djangoproject.com.
