LogoutView is currently undergoing a deprecation process for GET requests, which I believe is somewhat misguided. The idea to prevent logouts via GET request is a good one IMO. However, I think that the GET request should be preserved to render a "logout confirmation" template (similar to LoginView, or any other FormView)
I realize that this would not work well with the current behavior, in which a user can be logged out with a GET request. However, since this behavior is being deprecated, I feel like it may be a good time to reflect on whether or not the functionality of this view's GET request could be repurposed, instead of removing it altogether. If the default behavior is intended to be preserved (ie. no more GET requests for logout), then perhaps there could be a class attribute, such as 'require_confirmation = False' which, if set to True, causes the get() method to render a template. This would leave the door open for easy implementation of a logout HTML template, and would make the view more FormView-ish. I think this strategy would dovetail well with some of the changes that have been made to LogoutView during the 4.x releases, ie. making the behavior of LogoutView more like any other FormView (e.g. renaming get_next_page() to get_success_url()). This would also reduce the cognitive burden of having to deal with the unnecessarily (?) specialized behavior of the LogoutView (compared with other FormViews). Thanks for your consideration. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/5799e5ff-db28-47b4-ba8a-ce4e9783fd46n%40googlegroups.com.
