During project development our team needs to create several types of tokens. One of them will be used in case of account reset password. The second one is for account activation. Django itself has a good class for token generation called PasswordResetTokenGenerator. And now for account activation, we are using our own class called ActivationTokenGenerator, a subclass of PasswordResetTokenGenerator with overridden _make_hash_value method. And it works, but there is one problem. And this problem is called "timeout". For now, every token created with PasswordResetTokenGenerator will have timeout from settings.PASSWORD_RESET_TIMEOUT variable and can be changed only by changing this variable value. But what if we need different timeouts for different tokens? And I don't think we want changing timeout for *activation* token using a variable which is screaming about *password reset* (PASSWORD_RESET_TIMEOUT), we would like to use smth called ACTIVATION_TOKEN_TIMEOUT So there is a solution: why not create a timeout property for PasswordResetTokenGenerator class? Almost in the same way as it was done with _secret and algorithm fields.So our development team come up with an idea to create a PR which will add this functionality to the Django project. But before this we decided to search similar solutions in django PRs. And we found them! Ticket 30423 https://code.djangoproject.com/ticket/30423 sounds good enough, but it was closed with wontfix label.So the question is: why not to add this fine feature to the PasswordResetTokenGenerator ? And if people find this useful - why not to merge one o the existing PRs?
-- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/4f810acc-f2b4-4931-a84e-a59332a825f1n%40googlegroups.com.
