Hi everyone,

On the admin site, I've found a feature that existed in Django 2.2 but was 
lost with the update to Django 3.2.

In Django 2.2, if you clicked the "No, take me back" button on the delete 
confirmation page, the background color of the checked rows would remain 
highlighted and the action-counter display would remain counted up on the 
change list page. However, in Django 3.2, the background color of the 
selected row is not highlighted and the action-counter display is "0 of X 
selected".

Based on my investigation, I'm guessing that the problem is caused by the 
following fix to the JavaScript on the admin site that accompanies the 
update to Django 3.2.
https://github.com/django/django/commit/30e59705fc3e3e9e8370b965af794ad6173bf92b

The direct cause is that the following process in 
django/contrib/admin/static/admin/js/actions.js was removed in that fix.

~~~
        // Show counter by default
        $(options.counterContainer).show();
        // Check state of checkboxes and reinit state if needed
        $(this).filter(":checked").each(function(i) {
            $(this).parent().parent().toggleClass(options.selectedClass);
            updateCounter();
            if ($(options.acrossInput).val() === 1) {
                showClear();
            }
        });
~~~

In addition, it seems that the "checked" property of all elements in the 
"actionsEls" is now always false due to the change in the way the DOM load 
completion event is fired. We may need to take that into account when 
fixing.

Thanks in advance,


Akihito Yokose

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/dacf2948-66b1-4e64-a30e-84e418bd0d8bn%40googlegroups.com.
  • Mis... akiyoko
    • ... 'Adam Johnson' via Django developers (Contributions to Django itself)

Reply via email to