Hey Tobias. OK, it looks like I need to review it in more depth. Possibly it does all make sense, but the staff_member_required docs don’t read how I’d expect them to from this conversation.
Do you want to open a PR with suggested changes as a focus for discussion? Kind regards, Carlton On Tue, 9 Mar 2021 at 17:15, Tobias Bengfort <tobias.bengf...@posteo.de> wrote: > I checked the git logs and learned about a neat git feature: > > git log -L ':staff_member_required:django/contrib/admin/views/decorators.py > git log -L ':admin_view:django/contrib/admin/sites.py > > (requires `*py diff=python` in .gitattributes) > > The last commit to admin_view was in 2009. The last commit to > staff_member_required was 2015. It was documented shortly after that. > > So it seems like the documentation is up to date with the code. > > On 09/03/2021 14.50, Carlton Gibson wrote: > > Hi. > > > >> On 9 Mar 2021, at 14:33, Tobias Bengfort <tobias.bengf...@posteo.de > >> <mailto:tobias.bengf...@posteo.de>> wrote: > >> > >> According to [0] ... > >> > >> [0] > >> > https://docs.djangoproject.com/en/3.1/ref/contrib/admin/#the-staff-member-required-decorator > >> < > https://docs.djangoproject.com/en/3.1/ref/contrib/admin/#the-staff-member-required-decorator > > > > > > Those docs are unchanged since they were added 6 years ago. > > > https://github.com/django/django/commit/e8a758e941bb36f69b6224b73b00b9d6a814bbdc > > < > https://github.com/django/django/commit/e8a758e941bb36f69b6224b73b00b9d6a814bbdc > > > > > > A PR modernising the explanation may be in order. (I’d need to look at > > the matching history for admin_view judge fully…) > > > > Kind Regards, > > > > Carlton > > > > -- > > You received this message because you are subscribed to the Google > > Groups "Django developers (Contributions to Django itself)" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to django-developers+unsubscr...@googlegroups.com > > <mailto:django-developers+unsubscr...@googlegroups.com>. > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/django-developers/12592C48-40D3-40FF-832E-D6D14DA8B9B4%40gmail.com > > < > https://groups.google.com/d/msgid/django-developers/12592C48-40D3-40FF-832E-D6D14DA8B9B4%40gmail.com?utm_medium=email&utm_source=footer > >. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/5df94dc8-34f2-5484-15a9-bddac2eaec52%40posteo.de > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJwKpyQtVVsh%3DH1zv-JhLETNUH%3D%2B64w%3DZquAEGOOO4HDhTQiyw%40mail.gmail.com.
