Hi, I would like to work on this ticket https://code.djangoproject.com/ticket/28426. I am fairly new in the community and to Django development as well but this ticket seems not so Django specific and I am confident I can implement it. I have done some research already and found that we need to implement our own prompting for username and password. I would like to ask a couple of questions about this ticket.
urllib.request.urlretrieve() itself can be deprecated according to docs so I think we should move from using this function to using urllib.request.urlopen(). As I see this should not be that hard and I would like to do this in a separate PR if you agree. My question is based around basic auth. I would like to write some unit tests for it but I am not sure how to. I am not familiar with using LiveServer tests. Does it have the ability to provide basic auth interface? Am I right that for handling basic auth we should first try the download without credentials, then if we get 401 we should ask the user for username and password for the server and try with the given credentials in basic auth? For the credential prompts I would like to lift this function to our code: https://docs.python.org/3/library/urllib.request.html#urllib.request.FancyURLopener.prompt_user_passwd it is part of the FancyURLopener that is deprecated, but this function seams clean and good code. I hope that I found the right forum to ask my questions. Thanks Bence -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CALgZer5ofD54mBhSLrRkG-zPL5KtQCw7OgM9OHP1LfNS1OpvjQ%40mail.gmail.com.
