-Werror transforms warnings into exceptions. This is what happens with the asyncio case yes - but the exception is unraisable so python prints the stack trace and carries on as if no problem occurred.
Focussing only on the asyncio case may be counter productive. They are warnings by default and it requires a warning filter to convert them to exceptions, which are then unraisable. It’s easy to create unraisable exceptions through other mechanisms, such as in __del__ methods, but in practice thankfully rare. But I think in general any unraisable exception represents something you would want to know about in your test suite - just like a normal raisable exception. On Fri, 30 Oct 2020 at 13:38, Carlton Gibson <carlton.gib...@gmail.com> wrote: > > > On 30 Oct 2020, at 14:20, Adam Johnson <m...@adamj.eu> wrote: > > My proposal is to put this into the test runner for Django users > > > OK, I misunderstood. Gotcha. > > > … I'm not sure if failing the test run would *always* make sense. > > Always no, for the reasons given. Always awaiting every coroutine can be > hard, and not always (often not 🤔) significant. > > Let me rephrase, why isn’t python -Werror (or a more nuanced version of > that) sufficient? > > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/9AD9DB42-5B0D-41CA-995F-2DF4CD92783A%40gmail.com > <https://groups.google.com/d/msgid/django-developers/9AD9DB42-5B0D-41CA-995F-2DF4CD92783A%40gmail.com?utm_medium=email&utm_source=footer> > . > -- Adam -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM1cDG0vE_EYiLJ_5ih7%3D4Zh4Keofk3oQRx%2BFLFqEhM-ig%40mail.gmail.com.
