I've made a few comments on the PR requesting clarification, but I see this as a big win. Comparing it to the "minimum criteria for a DEP"...
It must be a clear and complete description of the proposed enhancement. > The only lack of clarity I see is around who's a member, and how renewing membership works. > The enhancement must represent a net improvement. > Definitely! This also won't just affect disabled people - I liked the citation of Alex Chan on the curb cut effect. > The proposed implementation, if applicable, must be solid and must not > complicate Django unduly. > Accessibility changes may add some complexity, but this will be far from "undue". They'll even be a legal requirement for many users. > Finally, a proposed enhancement must "fit" with Django's general > philosophy and architecture > A clear fit. We want to support diversity both inside the DSF and on the web. On Thu, 29 Oct 2020 at 11:01, Carlton Gibson <carlton.gib...@gmail.com> wrote: > Hello all. > > Can I ask the Technical Board for Review and Resolution > <https://github.com/django/deps/blob/master/final/0001-dep-process.rst#review--resolution> > on DEP 11 please? > > https://github.com/django/deps/pull/69/ > > (Please let me know if I've done that wrong.) > > Kind regards, > Carlton > > On Thursday, 22 October 2020 at 10:43:03 UTC+2 Carlton Gibson wrote: > >> Hi all. >> >> The DEP for creating an accessibility team is looking good. >> https://github.com/django/deps/pull/69 >> >> I'm going to ask for formal consideration shortly. >> If you have an interest/a moment, over the weekend say, to give it a >> glance before that, then any comments will be gratefully received I'm sure. >> >> Thanks. >> >> Kind Regards, >> >> Carlton >> >> >> On Wednesday, 16 September 2020 at 00:17:35 UTC+2 Thibaud Colas wrote: >> >>> I’d love to! But worth bearing in mind that I haven’t done any Django >>> contributions before. >>> >>> I decided to end my talk with a call for feedback on your DEP – this >>> feels like the ideal call to action to end on. >>> >>> On Monday, 14 September 2020 at 18:00:03 UTC+1 t...@carrick.eu wrote: >>> >>>> Carlton, I think that would be useful, thanks. >>>> >>>> Thibaud, shall I add you to the implementation team? It seems like >>>> you're doing more work on this than I am lately. I think we could still use >>>> one or perhaps two more people, but I think it's a good start. >>>> >>>> On Mon, 14 Sep 2020 at 16:44, Carlton Gibson <carlton...@gmail.com> >>>> wrote: >>>> >>>>> Hi All. >>>>> >>>>> Thanks for this. I'd be happy to play *Shepherd *if you need someone >>>>> to put their hand up. >>>>> I think that means I need to nag about getting it done. So... 🙂 >>>>> >>>>> Who's going to be on the team to do the first review, and then >>>>> subsequent work? Answer that and you have the Implementation Team. >>>>> I like that you've thought about how the team can refresh periodically >>>>> — I don't suppose the burden will be too great but folks tend to cycle-out >>>>> naturally, so good to plan for that. >>>>> Thibaud: Asking for hands in your talk seems sensible. >>>>> >>>>> Kind Regards, >>>>> >>>>> Carlton >>>>> >>>>> >>>>> >>>>> On Sunday, 6 September 2020 at 00:45:36 UTC+2 Thibaud Colas wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> Now that the DEP PR has been submitted I was wondering what the next >>>>>> steps would be. According to the documented DEP process I found, it’s at >>>>>> the "forming the team" >>>>>> <https://github.com/django/deps/blob/master/final/0001-dep-process.rst#forming-the-team> >>>>>> stage? How do you go about creating an *Implementation Team* and >>>>>> finding a *Shepherd*? >>>>>> >>>>>> The main reason I ask is that I’ll be giving a talk about >>>>>> accessibility at DjangoCon EU in a couple of weeks, and I thought it >>>>>> would >>>>>> be a good occasion to raise awareness of the issues with the Django >>>>>> admin, >>>>>> and mention this DEP. But I want to make sure I provide accurate >>>>>> information. >>>>>> >>>>>> Thanks in advance, >>>>>> >>>>>> Thibaud >>>>>> >>>>>> On Tuesday, 14 July 2020 at 09:37:01 UTC+1 Thibaud Colas wrote: >>>>>> >>>>>>> 🎉 it’s wonderful to see this happening! Re-reading through the >>>>>>> whole thing, as Tobias mentioned I also find it very easy to read, and >>>>>>> makes a good case. >>>>>>> >>>>>>> On Tuesday, 14 July 2020 at 09:24:15 UTC+1 t...@carrick.eu wrote: >>>>>>> >>>>>>>> I've added a PR to the DEPs repo to hopefully get some eyes on it: >>>>>>>> https://github.com/django/deps/pull/69 >>>>>>>> >>>>>>>> Thibaud, I think whatever you have the time and motivation for >>>>>>>> sounds good, all of those things are useful. If you're not sure about >>>>>>>> all >>>>>>>> the admin features, I think that's pretty normal. One project I've had >>>>>>>> on >>>>>>>> my mind for a while now is to build a simple django site that is >>>>>>>> essentially just there to use every feature of the admin, so I might >>>>>>>> bump >>>>>>>> that up the priority list, though it's somewhat daunting. >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Tom >>>>>>>> >>>>>>>> On Mon, 13 Jul 2020 at 01:15, Thibaud Colas <thibau...@gmail.com> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Update for the proof of concept CI tests from my side – thank you >>>>>>>>> Tom for the feedback. Here are the latest additions to the test suite >>>>>>>>> & >>>>>>>>> reports, still living at >>>>>>>>> https://thibaudcolas.github.io/django_admin_tests/, >>>>>>>>> >>>>>>>>> - Added as much as I know about in the admin, and now also outside >>>>>>>>> of it a bit (startproject welcome page, error pages) >>>>>>>>> - Separated the issues between Axe and HTML_CS so the numbers are >>>>>>>>> easier to understand >>>>>>>>> - Added anchor links everywhere for easier navigation >>>>>>>>> - I’ve also started a draft list of "things to (potentially) >>>>>>>>> audit", over at >>>>>>>>> https://github.com/thibaudcolas/django_admin_tests#scope-for-future-audits >>>>>>>>> >>>>>>>>> I think the next two big steps are what you mention: >>>>>>>>> >>>>>>>>> - Having a way to track the number of issues over time. Currently >>>>>>>>> the report overwrites itself every week (well, every build). If you >>>>>>>>> have a >>>>>>>>> suggestion on ways to demo this that would be useful please let me >>>>>>>>> know. >>>>>>>>> Currently I’m thinking sparklines for each test case could be nice as >>>>>>>>> a >>>>>>>>> proof of concept, and a sparkline for the total number of issues. Or >>>>>>>>> see >>>>>>>>> whether I should get out of my comfort zone a bit and find a >>>>>>>>> dashboard/graphing tool to send the metrics to and graph there. >>>>>>>>> - Testing more features of modeladmin. I don’t use it too >>>>>>>>> frequently myself so don’t really know what’s “easy” to enable – if >>>>>>>>> you >>>>>>>>> know of an existing test suite I could repurpose, or of an example of >>>>>>>>> using >>>>>>>>> a lot of functionality – I’d be keen to invest time to add it to my >>>>>>>>> test >>>>>>>>> site. >>>>>>>>> >>>>>>>>> Alternatively something else I could do is to file a ticket for >>>>>>>>> accessibility issues with the welcome page – I’ve tested it with >>>>>>>>> screen >>>>>>>>> readers, there are a few issues, but nothing that should be too hard >>>>>>>>> to >>>>>>>>> fix, and it might be a good demo of what reporting accessibility >>>>>>>>> issues in >>>>>>>>> general could look like? >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> >>>>>>>>> Thibaud >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tuesday, 30 June 2020 at 18:59:53 UTC+1 Tobias Bengfort wrote: >>>>>>>>> >>>>>>>>>> Nice writeup! I found it easy to read (I did not catch myself >>>>>>>>>> skipping >>>>>>>>>> paragraphs which is always a good sign). Contentwise, I would >>>>>>>>>> have no >>>>>>>>>> issue if this was accepted as is. Maybe I am forgetting about >>>>>>>>>> some >>>>>>>>>> important details though. >>>>>>>>>> >>>>>>>>>> I had just some ideas that might be good additions: >>>>>>>>>> >>>>>>>>>> - mention ATAG somewhere >>>>>>>>>> >>>>>>>>>> - It would be nice to have a real commitment to accessibility. >>>>>>>>>> Something >>>>>>>>>> along the lines of "accessibility bugs must be treated with the >>>>>>>>>> same >>>>>>>>>> priority as any other bugs". >>>>>>>>>> >>>>>>>>>> - The step from "leaving accessibility in the hands of >>>>>>>>>> individual contributors" to "you have to commit for 9 months" is >>>>>>>>>> a tad >>>>>>>>>> big. I keep wondering if we can do something to improve the >>>>>>>>>> options in >>>>>>>>>> between those. One idea would be to formalize an "a11y" keyword >>>>>>>>>> so >>>>>>>>>> interested contributors can easily find related tickets. >>>>>>>>>> >>>>>>>>>> tobias >>>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "Django developers (Contributions to Django itself)" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>> send an email to django-develop...@googlegroups.com. >>>>>>>>> >>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/d/msgid/django-developers/e65e3879-d74c-4401-9232-29eb0a73385cn%40googlegroups.com >>>>>>>>> <https://groups.google.com/d/msgid/django-developers/e65e3879-d74c-4401-9232-29eb0a73385cn%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Django developers (Contributions to Django itself)" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to django-develop...@googlegroups.com. >>>>> >>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/django-developers/f19d5f71-5095-4681-a0e6-0bcf2a17fbccn%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/django-developers/f19d5f71-5095-4681-a0e6-0bcf2a17fbccn%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/725b2167-f502-4d0f-b99e-f54b14de4cedn%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/725b2167-f502-4d0f-b99e-f54b14de4cedn%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Adam -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM0oXOTbSVekt7g-qE7X7_fujJPd8eZLrraN1AjywmyMiQ%40mail.gmail.com.
