I have submitted a PR with what I had before the discussion. Will work on it based on feedback.
Please see PR here. <https://github.com/django/django/pull/13114> On Thu, Jul 30, 2020 at 11:35 PM Shekhar Gyanwali < saykharng.gyanw...@gmail.com> wrote: > Hi Everyone! > > I am currently working on my first Django ticket 27807 > <https://code.djangoproject.com/ticket/27807>, which is to allow users to > customize username validation. My experience with Django and development is > very limited (junior developer level). I need some guidance on this. > > I am taking similar approach as password validation > <https://docs.djangoproject.com/en/3.0/topics/auth/passwords/#module-django.contrib.auth.password_validation> > (Thanks > to Jacob ) . In the current solution, I am following Django core validators > pattern which is to have __call__ method for validator. However, I have > noticed that password validator needs to have it's own validate method. > > Is it best to implement username validators similar to password validators > for the consistency and better user experience? > > What is the best approach here and what are the benefits of the best > approach? > > Your feedback is much appreciated. > > Cheers > Shekhar > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/6102cf17-b9be-4987-863f-1939feed93f8o%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/6102cf17-b9be-4987-863f-1939feed93f8o%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAHAmSnptjSUERW5F%2BNEwZSxV_GTrLrJ02Qn%3DsXCRL1eY9c_vFg%40mail.gmail.com.
