+1 for reverting ccc25bf . On Wed, 20 May 2020 at 19:54, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote:
> Hello, > > Commit ccc25bf refers to ticket #23919 in the commit message. In that > ticket, I argued that the __init__.py files should be kept: > https://code.djangoproject.com/ticket/23919#comment:102. No one brought a > counter argument. > > It's weird that the __init__.py files were removed anyway without further > discussion (that I can find with my browser's search on that page, at > least). > > It's fairly minor, but I think that ccc25bf should be reverted. > > Best regards, > > -- > Aymeric. > > > > On 20 May 2020, at 14:58, René Fleschenberg <r...@fleschenberg.net> wrote: > > On Github, Tim pointed out that with > > https://github.com/django/django/commit/ccc25bfe4f0964a00df3af6f91c2d9e20159a0c2 > , > various __init__.py files in Django's own code were removed. > > I tend to say it would be good to revert that change. Or we could update > the docs only, since they serve much more directly as an example for > user code. > > -- > René Fleschenberg > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/5d689d5c-01ab-d017-249c-a53a6d9b1f87%40fleschenberg.net > . > > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/C9E429E5-DC4C-4C47-8126-17B32D31D245%40polytechnique.org > <https://groups.google.com/d/msgid/django-developers/C9E429E5-DC4C-4C47-8126-17B32D31D245%40polytechnique.org?utm_medium=email&utm_source=footer> > . > -- Adam -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM2%3Dr4eANtv48ibUWn95U0qsRqobtaZoWR5VYAbnyyZ%2B0A%40mail.gmail.com.
