It seems that many of the people who want a different name are not understanding that this name is going to be exclusively for dealing with POST forms that are using the standard `x-www-form-urlencoded` media type*, *and won't be attempting to interpret any other media type. Some generic names, like "data" might be really good for a generic interface that interprets various content types, like Django Rest Framework has, but this isn't where Django is right now, and shouldn't be part of this question. All we are trying to accomplish is to give access to POST form data with the normal form submission content type that is not already accessible by the `query_params`, which are of the url parameters (like a GET form). This is just matching the current behavior of request.POST with a different name.
It is my opinion that the suggested `query_params` and `form_data` are great. While `form_data` can be slightly ambiguous if you're thinking of GET forms, once you realize that GET forms will show up in `query_params`, and are available even in a POST request, then all `form_data` would have left are the default POST forms. So +1 to the names as well. On Fri, May 8, 2020 at 10:30 AM Carlton Gibson <carlton.gib...@gmail.com> wrote: > > > On 7 May 2020, at 22:03, Florian Apolloner <f.apollo...@gmail.com> wrote: > > forms with method="GET" are legitimate and wouldn't end up in `form_data` > forms > with method="GET" are legitimate and wouldn't end up in `form_data` which > is imo quite confusing. Do we have any other options? > > > Would there be an issue with `.post`? > > Bar the suggested `query_params` change, the proposal would then amount to > “lowercase these names”. > > Then there’s the additional “Also rename `get` to `query_params`, to match > DRF”. > > > > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/66AB2042-8344-436B-A86A-2B9060BFAA17%40gmail.com > <https://groups.google.com/d/msgid/django-developers/66AB2042-8344-436B-A86A-2B9060BFAA17%40gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CABpHFHTCzjQS9xfOPoc7kG9fBsQSTEoguBwkrZPu5E7qdRe3Bg%40mail.gmail.com.
