Sorry I sent the mail prior to finishing, redoing fully from here:

I notice a piece of code inside ModelChoiceIterator that seems to keep going a 
bit back and forth, currently it looks like this:

        # Can't use iterator() when queryset uses prefetch_related()
        if not queryset._prefetch_related_lookups:
            queryset = queryset.iterator()

But before it looked like this:

        # Can't use iterator() when queryset uses prefetch_related()
        if not queryset._prefetch_related_lookups and queryset._result_cache is 
None:
             queryset = queryset.iterator()

Anyway, if you want to implement your own QuerySet class from scratch, which is 
the case of django-querysetsequence, and that's pretty useful to feed 
ModelChoiceFields, as long as you prefix object ids with content type ids which 
is pretty trivial.

Do you think it would be acceptable to start an effort with the objective of 
making django.forms.models rely purely on a public API of QuerySet ?

In this case, how would you accept to see that changed ?

Thanks in advance

Have a great day

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/8s1A9w1r5BtgXJCoWjwInlAzC5cQeYV3LWjFnGxcz-1qcMSxGyjAz6mdpUxmnB3wveLORpXmMcPjwVk-o_SbzTjy6ZMkbkn89qCH_i2S4n8%3D%40protonmail.com.
  • ... '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
    • ... '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
      • ... '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
        • ... charettes
          • ... '1337 Shadow Hacker' via Django developers (Contributions to Django itself)
            • ... charettes
              • ... '1337 Shadow Hacker' via Django developers (Contributions to Django itself)

Reply via email to