Hello Sanskar,

Thank you for your submission, from a quick look it seems to be heading in 
the right direction.

Would it be possible to break the large overview section into more granular 
sections where you describe how you roughly plan to tackle each of the 
point mention?

I personally have doubts about your desire to make minimal change to the 
schema editor and offload the logic to database_forwards instead of the 
other way around. That doesn't seem to be in line with a future deprecation 
of support for direct model passing. I'd much rather see us move all 
methods to (project_state, model_state, *other_state, 
**other_fields_and_flags) signatures and provide helpers to help 
third-party backends migrate (e.g. a method decorator that renders mode) 
then embedding logic for both paths in the schema editor and adding schema 
specific logic to Operation.database_forwards.

Simon

Le lundi 23 mars 2020 12:59:55 UTC-4, Sanskar Jaiswal a écrit :
>
> Hey everyone,
>
> Here is my proposal for GSoC. My project is based upon making use of 
> ModelState during the migrated phase of the project, rather than rendering 
> fake Models.
>
> https://gist.github.com/aryan9600/b1c2eaf445006c17e02e7677cf1098d5
>
> Feedback and criticism is highly appreciated.
>
> Thanks!
> Kind regards
> Sanskar
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/8e9a5959-d677-456f-9bb8-953e68162562%40googlegroups.com.

Reply via email to