Hello World, On Sunday, June 30, 2019 at 9:24:05 AM UTC+2, Aymeric Augustin wrote: > > As an experiment, let's just consider the first backwards-incompatible > change from the latest release: > https://docs.djangoproject.com/en/2.2/releases/2.2/#admin-actions-are-no-longer-collected-from-base-modeladmin-classes > > .... >
I think Aymeric is making a good point here on why any project like django-compat-patcher is ultimately doomed to be a failure. You simply cannot magically "fix" changes like this without knowing user intent. I can also remember the change from get_query_set to get_queryset (1.6 IIRC), you simply cannot magically patch that to work with multiple sublcasses and dynamic attributes. There will __always__ be situations where this will break in horrible and subtle ways. I'd argue that this would be worse then not being able to use a project that is not updated for a while. Pakal wrote in his initial mail: > With *less* work than currently, except small changes in procedures, we > can revive the majority of existing packages (except python2vs3 troubles), > ... > This is a bold argument for which I'd like to see some proof, also *less* work for whom? And last but not least, if one assumes all your arguments hold true, then why isn't django-compat-patcher used by existing 3rd party libraries (At least according to public usage https://github.com/pakal/django-compat-patcher/network/dependents)? Either the usecase you are suggesting isn't as strong as you make it to be or 3rd party packages are maintained well enough for this to be not a problem? Personally I also think that a package that wasn't updated since 2015 should probably not be magically patched to theoretically work on a current Django. Cheers, Florian -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7b076492-0ad7-4a06-8bef-008cd6fd91f0%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
