I feel like it would be worse as it would break formatting changes across multiple commits, creating an inconsistent formatting code base and generating large unrelated changes diff when altering a still untouched file which would make the review harder.
Cheers, Simon Le mardi 16 avril 2019 10:37:13 UTC-4, Jacob Rief a écrit : > > To address some of Curtis Maloney's concerns: > >> >> 1. automated code formatting will be a great boon - reduce work, lower >> barrier for new committers, reduce work for the fellows, etc. >> >> 2. there are issues with git history in doing "the great commit". >> >> 3. there are issues with black's formatting choices. >> >> > How about, instead of reformatting all the code in one big go, discarding > the "blame"-history, > instead we use a tool which only checks for formatting violations and > prevents to commit such > code. > > Such a tool, for instance is Coala https://coala.io/#/about?lang=Python > This could be added as a Pre-Commit Hook and prevents contributors to > create non-conformant > branches on GitHub. This would address the problem of some pull requests > not being merged > for a long period, because of minor formatting issues. > > It also would enforce new coding styles over a longer period, keeping code > annotations until > someone touches a file. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/211f3e33-b81d-421f-8609-5fe4d697a52b%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
