> > I find it hard to justify adding it to a project just to deal with this.
Why is it hard to justify adding it? django-filter is in the class of very stable django third party packages, and it's even maintained by Django fellow Carlton Gibson. * Is my understanding of the current process correct, or is there an easier > way that I've missed? I'd say that's right. If you're finding you need to do too much customization on the view, it's also fine to write your own based on the generic View class or a FBV. CBV's can get complicated quickly because of all the individual methods. Is this documented anywhere? > Sounds to me like you found all the relevant documentation. I'd also point out the unofficial docs site https://ccbv.co.uk/ by core developer Marc Tamlyn that aims to make Django's CBV's easier to understand, and the third party package http://django-vanilla-views.org/ by core developer Tom Christie that provides an alternative simpler CBV class tree that can be easier to customize. * Is there enough of a generic use-case where FormView / FormMixin / > ProcessFormView could be altered to support this? Or are there subtleties / > nuances in each implementation that make a generic solution hard to develop? > For changing where the form data comes from, don't you just need to override get_form_kwargs as per https://github.com/django/django/blob/master/django/views/generic/edit.py#L35 ? Without really diving into the problem I can't see anything else that seems to need changing, having done this you're definitely in a better position to suggest a change :) On Sat, 9 Mar 2019 at 00:55, Kye Russell <m...@kye.id.au> wrote: > Hi, > > Sometimes it is appropriate to for a HTML form to use the GET method for > submission (usually search / filter forms). > > My impression has always been that in order to build a FormView-based view > that acts on GET data, you have to override a few methods on your class > (which involves understanding how FormView works). Even as someone with a > fairly good understanding of these classes, I sometimes have to reference a > previously-written example to make sure I've got it right. > > I am aware of the existence of django-filter[0] which takes care of this > for you, however at times I find it hard to justify adding it to a project > just to deal with this. > > I have the following questions: > > * Is my understanding of the current process correct, or is there an > easier way that I've missed? > * Is this documented anywhere? I looked at the Django 'working with forms' > documentation[1], and whilst it discusses the different scenarios in which > you'd use GET vs POST, it does not seem to discuss implementations in a CBV > context. > * Is there enough of a generic use-case where FormView / FormMixin / > ProcessFormView could be altered to support this? Or are there subtleties / > nuances in each implementation that make a generic solution hard to develop? > > Sorry if this is the wrong avenue to discuss this. I am approaching it > from the position of wanting to alter Django to better support this use > case, but I'm aware that I may have just missed a Blessed method in the > docs. > > Kye > > [0]: https://github.com/carltongibson/django-filter > [1]: https://docs.djangoproject.com/en/2.1/topics/forms/ > > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CANK-ykkMtxezA9cHN8jQ_czLn6OYtdDn6JYbjNgASyyqHH-aAw%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CANK-ykkMtxezA9cHN8jQ_czLn6OYtdDn6JYbjNgASyyqHH-aAw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- Adam -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM0kFZd4uYm2e%3DqpuV3NwLtcauM-GaDbuo1b%3D%2BZ9A_fMxA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
