Adding sqlparse into the introspection code for SQLite specifically means it's going to be a runtime dependency for anything to do with migrations.
I'm alright having that be the case, but I do think we should make sure the tests run with SQLite as otherwise a large section of the most complicated code in migrations won't be tested properly. Andrew On Mon, 8 Oct 2018, 00:59 Ian Foote, <i...@feete.org> wrote: > Hi all, > > On my pull request (https://github.com/django/django/pull/10406) > refactoring how Django creates database constraints I introduced a > dependency on sqlparse in the sqlite introspection code. This allows Django > to correctly read information about constraints on sqlite, particularly the > name. > > When reviewing ( > https://github.com/django/django/pull/10406#issuecomment-424542217) Tim > Graham raised the question of whether we should make sqlparse a mandatory > requirement for the sqlite tests or if we should skip those tests that > require it. In later discussion ( > https://github.com/django/django/pull/10406#issuecomment-427362983), Tim > raised the point that the introspection code is used by migrations. > > I'm not clear myself what the best route forwards here is, so I'm bringing > it to Django Developers for discussion (as Tim suggested). > > Thanks, > Ian > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAFv-zfKadOeWit8M6GMmx4H2ChUCU6u%3DscHX8F7oBKJkHRbuVg%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CAFv-zfKadOeWit8M6GMmx4H2ChUCU6u%3DscHX8F7oBKJkHRbuVg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1upormR5UjCNMU7xXQiqeLtU%2BP-qBQAdgLx%2Be2Jno%2ByBew%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
