Thank you all for the feedback, I’ve changed the method to be bulk_update()
as this seems to be the most liked option. Naming things is hard, and while
bulk_update() isn’t perfect I think it’s a bit better than
bulk_update_fields() or just update_fields().




On 16 September 2018 at 10:19:40, Tobias Kunze (r...@rixx.de) wrote:

On 18-09-15 23:15:10, Adam Johnson wrote:
>> I agree bulk_save() maybe is not the best name as people might expect
>> signals to be sent, but are there any suggestions other than
bulk_update()?
>> Maybe something more accurate, like bulk_update_fields()? Or
>> bulk_save_fields()?
>
>bulk_update_fields also sounds good, the longer method name is probably
>balanced by the lower frequency of use.

bulk_update_fields() sounds fine to me, as it makes clearer what
happens. With bulk_update() alone, I'd expect the exact analogous
action to update() to occur, since we're already used to that pattern
from create() vs bulk_create().

update_fields() alone may also work. Upside: it's shorter. Downside:
it's not immediately clear that it takes an iterable and not an
instance. I'd be happy with both options.

Best regards,
Tobias

-- 
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/20180916091931.7hlmh2xc5eo5z7ws%40ronja.localdomain.

For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAFNZOJOHYTA-%3D6BYVm7Doe%3DE2%3DAWgnJ-F7%2B_UKgzAsiH%2B0bm-A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to