Hello Raphael, Thanks for your very, very helpful explanations.
Just another 2 questions: I saw that you did two things:
1.: you created a "class ReportsApp(AppConfig):" in
/plugins/reports/__init__.py - according to the Django docs[1] this
should go into /plugins/reports/apps.py
Why in the root plugin module?
and 2.: Why did you use "PretixPluginMeta"?
Why didn't you just use the AppConfig namespace?
Like:
class ReportsApp(AppConfig):
name = 'pretix.plugins.reports'
verbose_name = _("Report exporter")
name = _("Report exporter") # name clash
author = _("the pretix team")
version = XYZ
description = _("This plugin allows you to generate printable
reports about your sales.")
Except for the name clash, this would suffice?
Have you had a good reason for that? (I suppose...)
Thank you very much.
> [...]
>> I have written a IMHO better plugin handler:[...]
> I like it! It is more framework-agnostic than our approach and
> therefore probably more flexible. Our approach is a bit more tied to
> Django's internals and therefore makes some things easier, but some less
> clean.
Ok, thanks. I'm already working on extracting my plugin system and
making it more generic ;-)
I'll post a link when I can release a bit of code.
Christian
[1]
https://docs.djangoproject.com/en/2.1/ref/applications/#for-application-authors
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/ced1f07a-982a-a145-4e26-a3ce5aaf9c74%40nerdocs.at.
For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
