Hello, I reviewed the PR today — better late than never... It's looking good and it would be a great addition to Django 2.0.
The biggest outstanding problem is code duplication in django.db.models.sql.query. Advice from people who know a bit about this module would help a lot. Search for "It may be possible to simplify this further." on https://github.com/django/django/pull/7615 <https://github.com/django/django/pull/7615> and read from there. Thanks! -- Aymeric. > On 10 Aug 2017, at 20:12, Ian Foote <i...@feete.org> wrote: > > Hi all, > > I've been working on https://code.djangoproject.com/ticket/11964 to add > support for Check Constraints to the Django ORM and migrations framework. My > work can be found at https://github.com/django/django/pull/7615. > > I think the functionality is basically there, so what it really needs is some > testing on real-world use-cases and more eyes to suggest any further > simplifications or improvements that may be possible. > > Thanks, > > Ian > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/58b62be6-7eb1-2b20-3940-1394aa9e39dd%40feete.org. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/E76B6F76-C4B6-4A58-8206-56C0F53ECD8D%40polytechnique.org. For more options, visit https://groups.google.com/d/optout.
