I agree with Reinout and on the use of the present tense, so a commit message would read: "Adds password validation to prevent the usage of ..."
My mind finds this way easier to understand than: "Add password validation ..." Wim On Monday, 27 June 2016 13:55:54 UTC+2, Daniele Procida wrote: > > On Mon, Jun 27, 2016, Reinout van Rees <rei...@vanrees.org <javascript:>> > wrote: > > >Op 26-06-16 om 05:31 schreef Kevin Christopher Henry: > >> If anyone's put off by the hectoring tone of the imperative mood, it > >> might be better to think of it as the indicative mood. That is: > >> > >> (This will) "add password validation to prevent the usage of...". > >> > >> rather than > >> > >> (You must) "add password validation to prevent the usage of..."! > > > >"It might be better to think of it as...": it is exactly this extra > >thinkwork that everyone reading the messages has to do. We write it once > >and read it many times: what should we optimize for? > >In our source code, the answer is clearly that you should optimize for > >readability. > >Why is it suddenly different for commit messages? > > I'm inclined to agree with Reinout that a descriptive message makes more > sense and is easier to understand than one written in the form of an > instruction. > > Why would a log record be written as an imperative? > > "Updated gnools" tells you what has happened (and even "Updates gnools" is > a label saying what the thing it's attached to will do). > > "Update gnools" would make sense as the label for an interface button, but > not really as a record in a log. > > Apart from consistency with Git's own messages, I don't really see the > advantage. > > Daniele > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/88486c72-c77e-4bc8-89bc-9f87132e99aa%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
