Just to play devil's advocate... you're all worrying about one simple case;
there are infinite variants of it with subtle bugs, for example imagine the
same situation but with *Value*:
Whatever.object.filter(is_active=Value('false'))
The ORM can't predict the type of a *Value* call - pretty much by
definition, since it's a raw value passed to the database. So you might be
able to fix BooleanField for a few cases, but you can't fix them all..
On Friday, January 29, 2016 at 10:38:52 PM UTC, Chris Foresman wrote:
>
> Sorry, sbrandt noted the issue of subtle bugs, not Maxime.
>
>
> On Friday, January 29, 2016 at 4:37:51 PM UTC-6, Chris Foresman wrote:
>>
>> I have to agree here; it's pretty sloppy to not enforce an explicit
>> boolean value and can lead to subtle bugs. In addition to the one mentioned
>> by Maxime, consider the case of a nullable boolean field:
>>
>> >>> bool(None)
>> False
>>
>> Maybe that field has a better converter for possible values and
>> explicitly allows `None`, but I think it would be fairly trivial to add a
>> stricter check and pretty easy to fix code that's not backwards compatible
>> with find/replace.
>>
>>
>> On Friday, January 22, 2016 at 3:18:45 PM UTC-6, Maxime Lorant wrote:
>>>
>>> At least, the behaviour is predictable : it uses `bool(value)`. I
>>> believe it is not a bug but more a question about the input definition:
>>> should we allow non boolean value? I don't see any problem here accepting a
>>> string as a `True` value, it is the job of the user to ensure the value is
>>> castable to a boolean.
>>>
>>> The same behaviour is found on `IntegerField` for example:
>>> `Model.objects.filter(pk="foo")` raises `ValueError: invalid literal for
>>> int() with base 10: 'foo'` which implies the ORM tried to cast 'foo' as an
>>> integer.
>>>
>>> On Friday, January 22, 2016 at 8:51:41 PM UTC+1, Kaveh wrote:
>>>>
>>>> Today I discovered I can use strings and numbers to query on
>>>> BooleanFields.
>>>>
>>>> Let's say we have the following model:
>>>>
>>>> class Whatever(models.Model):
>>>> name = models.CharField(max_length=200)
>>>> is_active = models.BooleanField()
>>>>
>>>> The following queries return all instances which their `is_active`
>>>> field is True:
>>>>
>>>> Whatever.object.filter(is_active=True)
>>>> Whatever.object.filter(is_active='some_random_text')
>>>> Whatever.object.filter(is_active=777)
>>>>
>>>> and the followings return the ones which are False:
>>>>
>>>> Whatever.object.filter(is_active=False)
>>>> Whatever.object.filter(is_active='')
>>>> Whatever.object.filter(is_active=0)
>>>>
>>>> Is this behaviour intentional or is it a bug? Should queries on
>>>> BooleanFields accept strings and numbers?
>>>>
>>>
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/ec95ccb7-5ca0-410c-a52b-1ccf75f5d766%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
