Hi Josh, thanks for your reply. I was a little bit afraid of making PRs of interviewed code. So I made it now and the PR is here: https://github.com/django/django/pull/5108
Dne středa 5. srpna 2015 3:15:22 UTC+2 Josh Smeaton napsal(a): > > Hi Petr, > > Thanks for working on that ticket. I'm probably not the person to be > reviewing work in the admin, but here are a few ideas for getting your > patch noticed. > > 1. Create a pull request against the Django repository. Even if it's not > ready to be merged, a pull request makes it a lot easier to provide review > and comment on your changes. > 2. Provide a description of what your patch is aiming to do in the pull > request comments. "view_permissions" for admin don't tell me a whole lot, > why do we need view permissions? Answering that question will help review. > > Writing to the mailing list here is also good, but having your code > available as a PR makes it easier for people to jump from here to your code > and provide feedback where it counts. > > Regards, > > On Wednesday, 5 August 2015 02:37:01 UTC+10, petr....@auto-mat.cz wrote: >> >> Hi, >> >> 4 months ago, I have implemented view permissions for Django admin and >> posted it under following ticket: >> https://code.djangoproject.com/ticket/8936 >> >> The patch in my branch contains tests and documentation. >> >> I am willing to give my time to make this commited to official Django >> branch. But I would need to get some commits, suggestions and advises from >> more expert Django developers. >> >> Petr Dlouhý >> > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/10a8b3c8-a68e-4130-9bde-4364e62021d8%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
