I agree that perhaps making it part of signals is not in everyone's favour (as signals are kind of unloved) but I also like the simplicity of Christopher's approach - the patch is small and understandable, and using it is pretty easy (especially to upgrade existing code into "safe" code).
Unless it's going to be super easy to port transaction-hooks over, I think it might be nice to get this in and sealed (it's not adding too much more complexity). If transaction-hooks would land in core well, let's do that. As for the two bugs, I think it would solve the underlying problem, but not the bug as described (e.g. for 14051, it would stop refs being pushed in for uncommitted transactions). Still fine IMO, and definitely leave comments on them noting this if it does land. Andrew On Mon, Apr 27, 2015 at 10:23 PM, Aymeric Augustin < aymeric.augus...@polytechnique.org> wrote: > > On 27 avr. 2015, at 16:17, Christopher Adams < > christopher.r.ad...@gmail.com> wrote: > > So wrote an > <https://docs.google.com/document/d/1VtSduRYtAIZa4sOFvj_H0f3JfgXxf_vbxQ4RTlFBags/edit?usp=sharing> > RFC > <https://docs.google.com/document/d/1VtSduRYtAIZa4sOFvj_H0f3JfgXxf_vbxQ4RTlFBags/edit?usp=sharing> > and a prototype > <https://github.com/django/django/compare/django:master...adamsc64:modelsignal_sent_after_commit?expand=1> > branch > in Django to defer the invocation of certain handlers registered with > Django model signals optionally until after transaction commit. Any > thoughts? > > > > Hi Christopher, > > Thanks for working on this. In addition to what Carl said, have you read > https://code.djangoproject.com/ticket/21803 and > https://code.djangoproject.com/ticket/14051? I think they’re relevant > here. > > -- > Aymeric. > > > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CC456857-820D-45EB-A515-F62007041ABB%40polytechnique.org > <https://groups.google.com/d/msgid/django-developers/CC456857-820D-45EB-A515-F62007041ABB%40polytechnique.org?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1upyQdwxtw03EvRAZ1Mxma_ZX-xBkoc%2BiSdR5%2BHpTXBpZw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
