I like the idea of establishing a convention for discovering backend specific tests. As it is now, it seems that third-party backends need to have a customized version of Django's own runtests.py which duplicates a lot of code. Example for django-mssql: https://bitbucket.org/Manfre/django-mssql/src/1d8da0ee6dd4c1f1e32d29bf405dd8c7e682fba8/tests/?at=master
I'm not thrilled with the convention of storing them in a subdirectory of the backend itself (easier to keep code and tests separate, I think; also we moved contrib tests out of contrib for similar reasons), but that seems like an implementation detail that could be sorted out. Yichun, you can grep Django's tests for "connection.vendor" to see the backend specific tests we have now. There's only about 35 occurrences so as Shai alluded to, there wouldn't be huge about of code shuffle. On Monday, March 16, 2015 at 7:22:40 AM UTC-4, Shai Berger wrote: > > I can't answer for sure because there are still open issues there (e.g. > what > do you do in the face of multiple databases using different engines). But > for > the "clear cut" issues, my estimate is that they shouldn't take more than > a > few days. > > Shai. > > On Sunday 15 March 2015 14:03:44 Yichun Duan wrote: > > And another question, how long will this task take in your opinion? I > can > > hardly estimate it now. > > > > 在 2015年3月15日星期日 UTC+8下午7:07:11，Shai Berger写道： > > > > > On Sunday 15 March 2015 03:45:16 Yichun Duan wrote: > > > > Thank you. When you say "backend-provided tests", do you mean MySQL > > > > scripts, Oracle scripts or something else like these? Or just some > > > > tests based on django standard, which have marks to tell test runner > > > > the > > > > > > backend > > > > > > > they suite? > > > > > > I mean standard Django tests, which are located in folders inside the > > > backend > > > source. That is, Oracle-specific tests in > django.db.backends.oracle.tests > > > etc. > > > Today, the test-runner will not discover such tests and so will not > run > > > them > > > even if the specific backend is in use. > > > > > > In the current Django test-suite, there are several tests marked to > run > > > only > > > on a specific backend. I'd also like to remove them from there, and > put > > > them > > > into the backends. That's the "clean-up". > > > > > > Shai. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/1e595deb-593c-435e-9c62-3a58e6876c54%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
