I support the idea of introducing isort.
Didn't know isort before and give it a try on personal project.
It considers only the global import of the file (I mean on the
very top on my files and not in the methods / functions). Which
is exactly what it should do from my point of view.
On 01/29/2015 02:18 PM, Tim Graham wrote:
As a code reviewer, I've really appreciated that we've cleaned up the
code using flake8 and have automated "enforcement" via the CI server.
I'd like to extend the idea to apply to standardizing import ordering
using isort [1]. This mail is to advise everyone of the change and to
address any concerns.
Documentation:
https://github.com/django/django/pull/4008
Automated cleanups:
https://github.com/django/django/pull/4009
On a related note, the UI for flake8 errors isn't currently very good
(you have to look at the bottom of the Jenkins build logs). I'd like
to improve that by using a separate service that uses the GitHub
status API [2] so that the check can run separately from the tests
build. I don't want to reinvent the wheel though, so if there is an
existing service we can use for this, great. I'd like to also add
checks for documentation build and spelling errors, as well as isort
checks (assuming adoption per above).
[1] https://github.com/timothycrosley/isort#readme
[2]
https://github.com/blog/1935-see-results-from-all-pull-request-status-checks
--
You received this message because you are subscribed to the Google
Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected]
<mailto:[email protected]>.
To post to this group, send email to
[email protected]
<mailto:[email protected]>.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/d356e388-fa45-4fdf-871f-ce484a7b43bf%40googlegroups.com
<https://groups.google.com/d/msgid/django-developers/d356e388-fa45-4fdf-871f-ce484a7b43bf%40googlegroups.com?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Django
developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/54CB5092.90507%40arkade.info.
For more options, visit https://groups.google.com/d/optout.
