Hi All,
Should change tuples to lists in more places in the docs?
https://github.com/django/django/pull/3929
Collin
On Thursday, December 18, 2014 at 7:56:47 AM UTC-5, Carl Meyer wrote:
>
> On 12/17/2014 11:49 PM, Russell Keith-Magee wrote:
> > On Thu, Dec 18, 2014 at 7:48 AM, Carl Meyer <ca...@oddbird.net
> <javascript:>> wrote:
> >> This is clever, but on second thought I'm trying to figure out in what
> >> scenario a backwards-compatibility would actually occur here. In the
> >> context of a user's settings modules, global_settings plays no role at
> >> all: you can't add to a global setting default in your settings.py
> >> (unless you've imported global_settings yourself, which is certainly
> >> making use of undocumented internals).
> >>
> >> So it seems to me that the only scenario in which this would actually
> >> cause a back-compat problem would be if someone is using a tuple
> >> setting, which they are not setting themselves (and thus are using the
> >> global default), and they are adding to it in their runtime code (not
> in
> >> their settings file). For instance:
> >>
> >> my_ctx_procs = settings.TEMPLATE_CONTEXT_PROCESSORS + ('another',)
> >>
> >> The common case of appending to a setting in your settings.py (due to
> >> use of some kind of split-settings) should not be impacted at all
> >>
> >
> > That's a fair point. The benefit for an __add__ definition is likely to
> be
> > a lot smaller than I originally thought.
> >
> > The only place I can think that it might pop up is in older (pre
> > @override_settings) test harnesses; that said, a failure during test
> isn't
> > a major inconvenience
> >
> > So - I retract my suggestion - I think I can live with just documenting
> > this as a backwards compatibility.
>
> Works for me!
>
> Carl
>
>
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/38ba3ba6-86e3-40c5-b251-6a6ed2d3f3d0%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
