Well, neither, really, but, if anything, the latter. - I don't think there's any bugs in StaticLiveServerCase.
- I have changed all my tests to use the new class. it wasn't the end of the world. What I *am* saying is that, in my opinion, there's not much point in LiveServerTestCase if it doesn't do static files. So, to keep things simple, it would be simpler to remove it, and just have on LiveServer test class, that lives in .contrib if it has to... But maybe others would disagree? To explain a bit more -- what is LiveServerTestCase for? It's to let you run tests with (eg) selenium, against a "real" web server. And one of the most obvious reasons to do that is to test client-side stuff like javascript, ie stuff that depends on static files. And so that means that you have to either run collectstatic before every test run, or switch to StaticLiveServerCase. On 29 March 2014 18:10, Ramiro Morales <cra...@gmail.com> wrote: > On Sat, Mar 29, 2014 at 1:26 PM, Harry Percival > <harry.perci...@gmail.com> wrote: > > > > > [...] > > > > But I just wanted to express the fact that it feels a little > > counter-intuitive. I don't know enough to weigh how important it is to > > remove a dependency on a contrib app from the testcases framework, but, > as a > > user, having to remember that i need to run `collectstatic` before all my > > tests will pass is a bit weird. collectstatic is something i do on > servers, > > not on my local dev box. and LiveServerTestCase isn't much use without > > working static files. > > Are you saying that you need to run collectstatic before all your tests > when you make your test cases inherit from StaticLiveServerCase instead > of LiveServerTestCase?. Because if so, that's a bug I'd need to fix because > that's not the intended behavior and I'm the one behind this change. > > Or are you saying that you don't want to bother to edit your tests code > to replace StaticLiveServerCase with LiveServerTestCase as part of your > migration to 1.7? > > Regards, > > -- > Ramiro Morales > @ramiromorales > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Django developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/django-developers/SYktTEJXWc8/unsubscribe > . > To unsubscribe from this group and all its topics, send an email to > django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAO7PdF9xTf7rtLtemaSHUXeX8eqc7oR7wD-%3DZyL9LedjQ7ZxRA%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- ------------------------------ Harry J.W. Percival ------------------------------ Twitter: @hjwp Mobile: +44 (0) 78877 02511 Skype: harry.percival -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACFvh99crRT5Ne-6pZhUAQQ7_vC9PcBbRqxNi%3D0UJHSifpkWgg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
