Hey Russ, On Monday, September 30, 2013 7:17:14 PM UTC-6, Russell Keith-Magee wrote: > > Hi Rocky, > > On Thu, Sep 26, 2013 at 4:17 PM, Rocky Meza <rock...@gmail.com<javascript:> > > wrote: > >> >> Hi, >> >> I'm another one of the authtools devs. >> >> On Tuesday, September 24, 2013 6:04:17 PM UTC-6, Luke Sneeringer wrote: >>> >>> Good evening, Russell, et. al., >>> This is a problem that we ran into with authtools, what we ended up >>> doing was just running the tests 3 times[1]. I don't think this is a >>> realistic approach within Django core though. One of the main problems >>> with this is that you use get_user_model at the root level of the forms >>> module, so the Form will be declared against only one model--I don't know >>> what you can do though. Having email_auth as a separate app would probably >>> clear up this problem for the tests, but if that happens then we would just >>> have to concrete specific sets of forms, instead of more generic Forms, >>> which was the whole idea. The only situation where you should be switching >>> settings around is in tests, so I do think it is a little unfair to >>> compromise the generic nature of the forms just to appease the tests. >>> >> >>> Not only is it a realistic approach -- it is (within limits) what the > current Django core already does. In order to validate that Django's > pluggable user infrastructure actually does what it is supposed to do > (i.e., let people with different user models use default auth views etc), > Django's auth app ships 7 test User models, and large chunks of the test > suite are run for each of those models. It's not a case of running the > *entire* auth test suite repeatedly; it's matter of finding the parts of > logic that are User model dependent, and running *those* tests repeatedly. > Oh that's cool, I didn't know that. That makes some things easier.
> > So - it's entirely possible and realistic - as long as you don't bind one > specific User model into a global context. Which is one of the reasons why > having a separate app helps :-) > > Yours, > Russ Magee %-) > -rocky -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7075f774-3576-4716-b5d2-d5e3354474ef%40googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
