I'm still working at polishing after reviewing. I've deprecated `requires_model_validation` and `validate`. I've started at adding tests for contenttype fields: `GenericForeignKey` and `GenericRelation`.
I've updated gsoc2013-checks-review branch [1]. Now it's the same as gsoc2013-checks branch [2]. I will push new work to the latter while the former will remain unchanged. I'm working at contenttype tests in gsoc2013-checks-contenttypes [3] branch. The work is not finished yet and there are some failing tests. @Shai Berger: Thank you for creating the ticket. I'm sorry that I procrastinated accepting it -- I finally did it and proposed a patch. [4] [1] https://github.com/chrismedrela/django/tree/gsoc2013-checks-review [2] https://github.com/chrismedrela/django/tree/gsoc2013-checks [3] https://github.com/chrismedrela/django/tree/gsoc2013-checks-contenttypes [4] https://code.djangoproject.com/ticket/20814 Questions: 1. Output formatting. We decided that every error/warning will take one line plus additional one for a hint if it's provided. The justification is that a Django user may type "grep HINT" to filter all hints. But now I think it's unpractical since the lines with hints doesn't say which object is invalid. So we can: (1) put hint in the same line as the error message or (2) change the format to sth like this: applabel.modellabel: Error message. applabel.modellabel: HINT: Hint. 2. Is it allowed to use `GenericRelation` pointing to a model if the model lacks `GenericForeignKey`? 3. I've added unicode_literals import to django/core/management.py but this affected `BaseCommand.verbosity` default value. In order not to break commands, I left the attribute as a bytestring [5]. Changing it to an unicode breaks some admin_scipts tests, i. e. `CommandTypes.test_app_command` expects in stdout: ... options=[('pythonpath', None), ... ('verbosity', '1')] while the command prints: ... options=[('pythonpath', None), ... ('verbosity', u'1')] [5] https://github.com/chrismedrela/django/blob/09579fdafc05dea90db41f519b26655010a50ac2/django/core/management/base.py#L169 -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. For more options, visit https://groups.google.com/groups/opt_out.
