Hi Jacob, Sounds great. I'll update the patch and see if I can come up with some tests. Thanks!
Aron On Mon, Oct 29, 2012 at 5:32 PM, Jacob Kaplan-Moss <ja...@jacobian.org>wrote: > Hi Aron -- > > Thanks for the interest; looks like a pretty nice addition. > > Looking at the patch, I see a couple things you could do to help it > get in quicker: > > * Update the patch so that it applies against he latest development > trunk. Looks like the patch is 2+ years old, so the chances are it > will no longer apply. You could then upload a new patch to the tracker > or open a pull request over on GitHub and note the pull-request number > in Trac. > > * There's no documentation or tests, both of which are usually needed > to get a patch accepted. There probably doesn't need to be much in the > way of documentation -- just a note that if pynotify is installed that > it'll be used. Testing's another story: this is likely to be something > that's really tricky to test. If you come to the conclusion that this > simply can't be tested than that might be OK, but you should > explicitly explain your reasoning behind testing on the ticket page. > > Thanks! > > Jacob > > On Mon, Oct 29, 2012 at 4:16 PM, Aron Griffis <a...@arongriffis.com> > wrote: > > I've noticed that the auto-reload support isn't kind to my laptop > battery, > > so I was happy to find that somebody's already done the work to get > inotify > > support into the autoreloader. The patches are in > > https://code.djangoproject.com/ticket/9722 > > > > This ticket seems to have been around for a while without an owner. Is > there > > something I can do to help get it in? > > > > Thanks, > > Aron > > > > -- > > You received this message because you are subscribed to the Google Groups > > "Django developers" group. > > To post to this group, send email to django-developers@googlegroups.com. > > To unsubscribe from this group, send email to > > django-developers+unsubscr...@googlegroups.com. > > For more options, visit this group at > > http://groups.google.com/group/django-developers?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-developers@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
