On 8 elo, 18:12, Flavio Curella <flavio.cure...@gmail.com> wrote:
> Hi,
>
> I've made some work onhttps://code.djangoproject.com/ticket/16455and I
> think I'm close to have it ready for checking.
>
> Can I have a quick review from the committers? I'm mostly interested in
> feedback about:
>
> * the v8 patch installs multidimensional index for columns with more than 2
> dimensions. From the PostGIS docs, seems like this kind of indexes are
> slow, and I can't fiind any advantages to use them. Patch v7 doesn't
> install the indexes. Any preference about which patch should we use?
> * testing the patch: do already existing tests cover? if not, where's the
> most appropriate place where to put the new tests?
> * documentation.
>
> Thanks,
> Flavio.

The only question I have is about the index: is having no index worse
than having a slower than Postgis 1.5 index. (Assuming I understand
the issue correctly the Postgis 2.0 version of the index is 2-5x
slower to query than the 1.5 version).

Otherwise the patch looks mostly good on a quick glance. Notably my
GIS understanding is low, so I hope somebody knowing that part of the
code could take a look.

 - Anssi

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to