Le 22 mars 2012 13:22, Łukasz Rekucki <lreku...@gmail.com> a écrit : > If the whole patch can't be merged, lets at least fix that bug[2]. Is > there any work I can do to make it happen? > [2]: > https://github.com/lqc/django/commit/84dc450ec861e34de068fde891537f0481342ef7
Hi Łukasz, Let's try to get this fix in 1.4. Since the change in the tests isn't significant, it boils down to replacing two `dict`s which `SortedDict`s. Since a `SortedDict` is a subclass of `dict`, this change looks safe. In a comment [1], you said: > there are a few places that relabel aliases and ruin the order, like > QuerySet.change_aliases(). (...) I fixed this, by using change_map = > SortedDict() in QuerySet.split_exclude. This should probably apply to all > change_maps when working with aliases. This implies that your fix isn't complete, is it? Could you clarify? Thanks! [1] https://code.djangoproject.com/ticket/17758#comment:2 -- Aymeric. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
