> > > > Obviously, this function cannot change in behaviour or name, so I > > suggest altering the docs, dropping the clause about indicating that > > the user has provided username and password to make it clearer what > > this method does. > > It does prove that they've authenticated, in that request.user will contain an AnonymousUser if they're not logged in, which overrides this method to always return False. If they are, then they'll get their actual user, which will return True.
Sorry - I only just worked out what your actual objection was. The function name does indeed only make sense in the form of the user given to you in the request object - I agree with you in that sense, and that the documentation should be clarified to make this clear - perhaps by removing the 'username and password' bit, or maybe by noting that this method is most useful in the sense of the request user? Cheers, Luke -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
