On Thu, Dec 8, 2011 at 3:31 PM, Jonas H. <jo...@lophus.org> wrote: > 2.) I don't like wasting my time, so I won't write extensive documentation > before the patch gets accepted
I'm sorry, but that's just not how we do things around here. Documentation isn't an afterthought; is as important -- more even -- then the code itself. In order for a patch to be considered "done", it needs documentation. If you don't feel the same that's fine, but you'll need to connect with someone who doesn't see documentation as a waste of time. Otherwise with a million patches to review I'm going to prioritize the ones that have documentation, and yours'll get lost. > 3.) Many changes can't be tested in a useful manner using unittest. For > instance the non-integer primary key patch should really be tested using > integration tests -- but that requires complex mocking which takes a lot of > time. Again I'd like to not waste my time. I'm willing to write tests and > docs once the patch is accepted. Like documentation, I don't see tests as a "waste of time", either. Again, there are many other patches to reivew, so I'm going to pick the ones that're closer to done. I *really* want to see this work merged so that django-nonrel can become a plugin and not a fork. But without tests or docs it's just not gonna happen. Jacob -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
