On Nov 22, 1:50 am, Ian Kelly <ian.g.ke...@gmail.com> wrote: > On Mon, Nov 21, 2011 at 3:53 PM, Anssi Kääriäinen > > <anssi.kaariai...@thl.fi> wrote: > > 1. It could be better if regex_lookup did the redirection to the > > correct regex_lookup implementation. As is, dbwrapper needs to know > > internals of ops, and ops rely on internals of dbwrapper. > > Good call. There's really no reason for any of this to be in the > wrapper. Moving it all into ops will result in cleaner code, and if > the user is not using regex filters, there is no need to do a version > check in the first place. > > > 2. What happens if that ValueError is hit and regex_lookup is called? > > I hope it isn't actually possible to hit the ValueError. > > AFAIK it's not. The ValueError only guards against getting a weirdly > formatted version string from the database. If it did get hit, I > think that regex_lookup would result in an infinite recursion, which > we should definitely fix. > > > 3. Is that TODO still accurate? > > No. I think it was based on an incorrect assumption about how > multi-db would work.
I can do a patch for this if needed. Are you (or somebody else) working on this? - Anssi -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
