Thank you for reviewing it. Cheers, Martin
On Mon, Jun 27, 2011 at 2:29 PM, Russell Keith-Magee <russ...@keith-magee.com> wrote: > On Mon, Jun 27, 2011 at 12:58 AM, Martin Green > <martin.spe...@googlemail.com> wrote: >> The unittest client currently does not allow for the testing of >> non-formset errors. I have made a ticket for this >> https://code.djangoproject.com/ticket/11603, which now has an upto >> date patch for adding it into trunk. Could I check that: >> >> * this functionality is desired. > > Yes, it's desired -- hence the 'accepted' status given to the ticket. > If it wasn't desired, the ticket would have been closed; if the ticket > was in an uncertain state, it would be in DDN. > >> * what version of django it should be aiming for. Currently the >> documentation states it was added to SVN, should this be changed to >> 1.4, and some suitable release note added? Can I presume if it is >> added to trunk that it will become part of django 1.4 in due course? > > It looks like you've worked this out for yourself -- but for the > record, development *always* happens against trunk, and any > documentation in the patch should reflect whatever 'trunk' is at the > time the patch is submitted. > > Procedurally, once your patch is uploaded, all it needs is a review > from an independent member of the community, who is put their seal of > approval on the ticket and mark it ready for checkin. To that end, > I've just done a quick review of your patch, and it looks good to me, > so I've moved it to RFC. > > As soon as a core developer gets some spare time, your patch will be > committed and become part of trunk. > > Thanks for the patch! > > Yours, > Russ Magee %-) > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-developers@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
