On Thu, Jun 2, 2011 at 11:30 AM, Ramiro Morales <cra...@gmail.com> wrote:
>
> o We added an inner template block inside breadcrumbs one, we called it
> crumbs, among other cleanups in the breadcrumbs code. Is it worth it?
Jannis posted this comment in the ticket:
What's the purpose of the crumbs block? Isn't that a bit OT for this
ticket and would make upgrading harder?
We initially though it would allow to reduce the duplication of HTML
code in the breadcrumbs and help to fix the inconsistent nesting of
the 'breadcrumbs' template block and an 'if not is_popup' contidional
used in some of the templates but I see now it isn't worth it and it
introduced its own inconsistencies.
I've reverted that and attatched a new [1]patch to the ticket.
Something I forgot to mention in the first email is that the changes
introduce (for me) six errors like this in the admin_views regression
tests:
======================================================================
ERROR: testAdminIndex (regressiontests.admin_views.tests.NeverCacheTests)
Check the never-cache status of the main index
----------------------------------------------------------------------
Traceback (most recent call last):
File "tests/regressiontests/admin_views/tests.py", line 2610, in
testAdminIndex
response = self.client.get('/test_admin/admin/')
File "django/test/client.py", line 445, in get
response = super(Client, self).get(path, data=data, **extra)
File "django/test/client.py", line 229, in get
return self.request(**r)
File "django/core/handlers/base.py", line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "django/contrib/admin/sites.py", line 209, in wrapper
return self.admin_view(view, cacheable)(*args, **kwargs)
File "django/utils/decorators.py", line 91, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "django/views/decorators/cache.py", line 77, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/sites.py", line 192, in inner
return view(request, *args, **kwargs)
File "django/views/decorators/cache.py", line 77, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/sites.py", line 345, in index
'admin_url': reverse('admin:%s_%s_changelist' % info,
current_app=self.name),
File "django/core/urlresolvers.py", line 398, in reverse
*args, **kwargs)))
File "django/core/urlresolvers.py", line 344, in reverse
"arguments '%s' not found." % (lookup_view_s, args, kwargs))
NoReverseMatch: Reverse for 'comments_comment_changelist' with
arguments '()' and keyword arguments '{}' not found.
But strangely enough, e.g. Florian doesn't see them.
These errors aren't reproducible when running the admin_views tests
alone, nor either using --bisect or --pair
Debugging so far shows that that 'comments_comment_changelist' URL is
affective available in the AdminSIte instance URL map at the point
the NoReverseMatchexception is raised (AdminSite.index() view).
Any idea or hint bout what could be the problem is welcome.
Regards,
--
Ramiro Morales
1. https://code.djangoproject.com/attachment/ticket/15294/15294.2.diff
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
