Hi Eduardo, I will definitely write and attach proper tests, but I think there is one decision to make first: Are hanging URLFields problem enough to make Django behave differently on Python <=2.5 and >=2.6 (even if the solution only changes the behavior for people that explicitly opt-in for that and explicitly the timeout argument of the URLField)?
Even if my answer to this particular case is positive, I think there are contrary opinions and I am asking you for yours. Best, Fabian On Friday, May 6, 2011 at 9:18 AM, legutierr wrote: > Hi Fabian, > > Are there tests that isolate this functionality? If there are, I can > run them against 2.5 and 2.6 to give you some independent > verification. > > If not, you should look into how to run the Django test suite, and > write some targeted tests. > > Regards > > Eduardo > > > On May 5, 3:07 am, Fabiant7t <fabian.topfst...@gmail.com> wrote: > > Hi everyone, > > > > verifying unresponsive URLs still hangs. There is ticket #9857, raised > > two > > years ago, which propagates using a timeout argument on an URLField > > level. > > > > Unfortunately, urllib2.urlopen (which is used by URLValidator to > > verify the > > URL) introduced a timeout support in Python 2.6 and Django requires > > 2.4+. > > > > For us, having the admin hang if an external ressource is unresponsive > > is a > > blocker and I would love to introduce an explicit timeout argument on > > URLFields that Python 2.6+ respects and Python 2.4-2.5 ignores. I > > wrote a > > patch and attached it to the > > ticket:http://code.djangoproject.com/ticket/9857 > > > > Any thoughts? > > > > Best, > > Fabian > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-developers@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
