On Mon, Mar 28, 2011 at 11:22 AM, Waldemar Kornewald
<wkornew...@gmail.com> wrote:
> I do agree that it's too complicated (esp., the forms) and I plan to
> improve django-filetransfers in this regard. The biggest complexity
> comes largely from file upload handling (which I understand isn't a
> problem you're trying to solve right now). If your main goal is to
> only handle private file downloads then django-filetransfers already
> provides a serve_file() view which does exactly that (the only
> difference is that it doesn't use a middleware-based solution).

Right, it introduces Yet Another Setting, which I'm really trying to
discourage. It's not your fault at all, but I'm going to look very
skeptically upon any patch that introduces new settings without a
great reason. I'm really trying to avoid setting creep: Django 1.1 had
87 settings, Django 1.2 had 123, and Django 1.3 has 137. This has to
stop.

More importantly, your approach, again, *requires* a patch to Django;
my proposed one doesn't. This is a good thing since it'll allow anyone
using older versions of Django access to the feature. If I'm thinking
about it right, a HttpResponse + middleware approach could work all
the way back to 1.0. (Maybe?)

> However, there are other use-cases and hosting setups. For instance,
[...]

Look, you're probably right. But I'd prefer to try the simple way
first and only do something complicated if the simple approach doesn't
work. Your approach, to my eyes, mixes a lot of unrelated stuff
together. If I've got that wrong, you need to explain to me (and
anyone else) why uploads and downloads belong together in the same
patch and why a simple "just support X-Sendfile and friends" patch
can't possibly work.

Jacob

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to