On Wednesday, 22 December 2010 at 8:24 PM, James Bennett wrote: > I've just opened ticket #14937[1] with a patch implementing what > seemed -- last time around -- to be the consensus fix for the ongoing > fracas that is the list of "state" choices in contrib.localflavor.us. > The patch attempts to avoid international incidents by use of > relatively fine-grained sets of choices, and by adding a new model and > form field which, rather than claiming to represent "states", merely > represent locations for which the United States Postal Service handles > mail. > > As we're about to go into beta, and thus feature freeze, I'd really > love it if someone (or several someones) could take a look and weigh > in; if the patch is suitably diplomatic, I'd like to get it in before > we freeze so 1.3 can ship supporting everywhere USPS will deliver to. > > [1] http://code.djangoproject.com/ticket/14937 > > > > James and I have discussed this on IRC, so for posterity...
I'm fine with the patch as presented. It provides a good set of basic options, but enough flexibility to set up any combination you might happen to need. The only part that I can see as even remotely controversial is the decision to include armed forces codes in STATE_CHOICES. This was raised separately as #9022. As I see it, there are two ways of looking at #9022: a) Not having armed forces codes in STATE_CHOICES is a bug b) Changing STATE_CHOICES would be strictly backwards incompatible. Being antipodean, I have no skin in this particular game. If a US local (read, James) is happy to call the absence of armed forces codes a bug in STATE_CHOICES, I'm happy to sign off on that. No matter what decision we make, *someone* is going to be unhappy; if the change makes sense, and we document the potential incompatibility, we might as well make the change. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
