Can anybody rewiew the patch? On Wed, Oct 13, 2010 at 6:35 PM, Alex Kamedov <kame...@gmail.com> wrote:
> Hi All, > > I uploaded patch with tests and little improvements > > http://code.djangoproject.com/attachment/ticket/8054/8054-list-column.5.diff > I think it ready for review. > > I really sorry, but I couldn't write good documentation because English > isn't my own language. The maximum of my possibility in writing docs is > here http://code.djangoproject.com/wiki/ListColumns For more examples > see folder admin_listcolumn in regression tests provided by last my patch. > > Cheers, > > Alex Kamedov > > On Wed, Oct 13, 2010 at 2:12 AM, Gabriel Hurley <gab...@gmail.com> wrote: > >> Hi alekam, >> >> This is certainly the kind of ticket that we want to deal with in 1.3 >> since it's been around so long and deferred a couple times. Starting >> the discussion here is definitely the right way to make it happen. >> >> That said, at the very least it needs a thorough code review, a full >> set of tests, and good documentation before it can be included. >> >> I'm not personally sold on the way the functionality is implemented, >> but I'd have to think on what would be preferable. I'm sure others >> will have stronger opinions on it one way or the other. >> >> All the best, >> >> - Gabriel >> >> On Oct 12, 9:47 am, alekam <kame...@gmail.com> wrote: >> > Hi All, >> > >> > I found very useful ticket #8054. This ticket has accepted status and >> > assigned to brosher about 2 years. The problem describes on ticket >> > detail page and in the wikihttp:// >> code.djangoproject.com/wiki/ListColumns >> > The ticket has patch witch passes all existing regression tests and I >> > plan to write unit tests for it. >> > It is real to add ticket #8054 to 1.3 milestone? >> > >> > Cheers, >> > >> > Alex Kamedov >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers" group. >> To post to this group, send email to django-develop...@googlegroups.com. >> To unsubscribe from this group, send email to >> django-developers+unsubscr...@googlegroups.com<django-developers%2bunsubscr...@googlegroups.com> >> . >> For more options, visit this group at >> http://groups.google.com/group/django-developers?hl=en. >> >> > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
