Hi, On Aug 31, 5:52 am, "burc...@gmail.com" <burc...@gmail.com> wrote: > Why you patched Django instead of making a connector so everyone would > be able to use your template engine without patching django?
This is how the whole thing started. I started a new job and the one that was in charge of the projects before me chose to use django. I had never used django before this job. After a while that I spent time to develop new tags and filters especially for new projects, I began to think a way to implement a template engine that would let me no more write sort of "plugins" like tags and filters, a thing that really bother me. As all the previews projects were based on django the easier and faster thing to do was to start changing the django template. Now that I'm back working on my business projects (that as you can understand is the priority) I can think what to do with it. I can keep it just mine but at first I thought I could have an opinion from you. > Looking at your django patch, you also seems to have a typo in your > Http500 page rewrite: > -Request Method: {{ request.META.REQUEST_METHOD }} > -Request URL: {{ request.build_absolute_uri|escape }} > +Request Method: {{ request.META['RQUEST_METHOD'] }} > +Request URL: {{ escape(request.build_absolute_uri) }} Yes thanks, you are right, bad typing. > From the engineering point of view, you did nothing important. In > fact, I think, you did a bad thing to Django: > By increasing the number of incompatible template engines for django, > you fraction the user base of each one, so you decrease the overall > quality of Django solutions, and Django plugins won't be that good (if > they provide any templates). I believe, new template engine should be > made only if it will be much better than old one (i.e, look at Razor > template engine from Microsoft ASP.NET team). I know that but it is a completely different platform/system/.... For the "incompatibility" issue I agree with you. To have only template engines fully compatible is one of your priorities. I understand and no problem with that. I sent you my work as you could have a look at it and see if it is interesting and, as I said already many times, if you had find it interesting it could be used as you wish. ABSOLUTELY in my mind there was NOT the idea of proposing a changing to the django template engine. > Your work also makes me think you haven't ever heard of Jinja2 and > Mako, both of which already do what you need (python programming in > templates), but have good documentation and have proper way to connect > to Django. In my opinion this is not true. I know Jinja and it works differently. Just looking at the Variables and Filters part of the documentation (or looking at the source if you prefer) you can see that it's different. For example I didn't want to do something like this (as in Jinjia is needed): {% if loop.index is divisibleby 3 %} > From the teenager point of view, look, you created new cool template > engine! Wow! You rock! ..no comment about this. Gabriele -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.