On Thursday 27 May 2010 17:09:58 Brian Rosner wrote: > > = Options = > > > > We could: > > 1) add 'STATIC_URL' and use it for widgets and all other media. > > 2) add 'USER_MEDIA_URL' and 'USER_MEDIA_ROOT' and use them for > > file storage. > > I am torn between these two. I am in favor of both to some extent. > I like the direction of being more clear about which is used by > FileFields. On the other hand calling the static resources for a > site STATIC_* seems the most correct to me. > > Of course Pinax had to take some direction and since we couldn't go > changing all the FileFields of the world we had to introduce new > settings. My stance would definitely favor option 2 for the added > clarity it provides. Pinax could end up with best of both worlds > ;-)
Thanks for your feedback, it's good to have some input from Pinax developers on this. I knew you had adopted method 1), but I don't think Django doing 2) causes you much pain - you just need to set STATIC_ROOT = MEDIA_ROOT, STATIC_URL = MEDIA_URL in your settings, and add USER_MEDIA_* and nothing else would need to change. > > Finally, once these things are sorted out, is this a small enough > > change that I should go ahead and commit it, or should I wait for > > voting on Django 1.3 features? > > I suppose this is dependent on whether we want to introduce app > media handling or if we want this to separate from that. In my > opinion I can see them as two different bits that be done > independently. Agreed. It could be done separately, but that might some confusion. I'll probably make a branch in my bitbucket repository, and wait and see if anyone proposes app media handling for 1.3. Cheers, Luke -- "Oh, look. I appear to be lying at the bottom of a very deep, dark hole. That seems a familiar concept. What does it remind me of? Ah, I remember. Life." (Marvin the paranoid android) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
